- Dialog pages currently have no titles or crumbs, and look shoddy. Add titles and crumbs.
- Dialog titles aren't always great for crumbs, add an optional "short title" for crumbs.
- AphrontDialogResponse is pure boilerplate. Allow controllers to just return a DialogView instead and get the same effect.
- Building dialogs requires a bit of boilerplate, and we generally construct them with no explicit "action", which has some issues with T4593. Provide a convenience method to set the viewer and get a reasonable, explict submit URI.
Details
Details
- Reviewers
btrahan chad - Commits
- Restricted Diffusion Commit
rPd8713f6f0b8c: Make dialogs a little easier to use
- Viewed dialog on its own.
- Viewed dialog as a dialog.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- dialog1
- Lint
Lint Passed - Unit
Tests Passed