Page MenuHomePhabricator
Differential D8560

Modernize OAuthServer PHIDs and Queries
ClosedPublic
Actions

Authored by epriestley on Mar 18 2014, 1:32 AM.
Tags
None
Referenced Files
F14065370: D8560.diff
Tue, Nov 19, 4:24 AM
F14051523: D8560.diff
Fri, Nov 15, 1:46 AM
F14040279: D8560.diff
Mon, Nov 11, 8:41 AM
F14038508: D8560.id20325.diff
Mon, Nov 11, 12:06 AM
F14022691: D8560.diff
Wed, Nov 6, 6:44 PM
F14008950: D8560.id20325.diff
Wed, Oct 30, 8:11 AM
F14008741: D8560.diff
Wed, Oct 30, 6:02 AM
F13994536: D8560.id20325.diff
Wed, Oct 23, 6:50 AM
View All Files
Subscribers
chad
epriestley

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP8909f8ec599b: Modernize OAuthServer PHIDs and Queries
Summary
  • Modernize PHID types.
  • Implement PhabricatorPolicyInterface.
  • Make queries policy aware.
Test Plan

Browsed client and authorization lists.

Diff Detail

Repository
rP Phabricator
Branch
oauths1
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley updated this revision to Diff 20313.Mar 18 2014, 1:32 AM
epriestley retitled this revision from to Modernize OAuthServer PHIDs and Queries.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
Herald added a subscriber: epriestley.Mar 18 2014, 1:32 AM
btrahan accepted this revision.Mar 18 2014, 1:48 AM
btrahan edited edge metadata.

sweet. existing policy stuff worked really well here IMO.

This revision is now accepted and ready to land.Mar 18 2014, 1:48 AM
epriestley added a subscriber: chad.Mar 18 2014, 2:43 AM

Yeah -- the OAuthServer application is in pretty good shape in general, it's just an iteration behind on UI kit and infrastructure since we wrote it before policies, applications, appsearch, @chad made everything pretty, etc.

epriestley closed this revision.Mar 18 2014, 8:28 PM
epriestley updated this revision to Diff 20325.

Closed by commit rP8909f8ec599b (authored by @epriestley).

Revision Contents
Changeset List

Diff 20313

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/oauthserver/controller/client/PhabricatorOAuthClientListController.php

Loading...
View Options

src/applications/oauthserver/controller/clientauthorization/PhabricatorOAuthClientAuthorizationListController.php

Loading...
View Options

src/applications/oauthserver/phid/PhabricatorOAuthServerPHIDTypeClient.php

Loading...
View Options

src/applications/oauthserver/phid/PhabricatorOAuthServerPHIDTypeClientAuthorization.php

Loading...
View Options

src/applications/oauthserver/query/PhabricatorOAuthClientAuthorizationQuery.php

Loading...
View Options

src/applications/oauthserver/query/PhabricatorOAuthServerClientQuery.php

Loading...
View Options

src/applications/oauthserver/storage/PhabricatorOAuthClientAuthorization.php

Loading...
View Options

src/applications/oauthserver/storage/PhabricatorOAuthServerClient.php

Loading...
View Options

src/applications/phid/PhabricatorPHIDConstants.php

Loading...
Phabricator · Built by Phacility