Fix validation of Harbormaster HTTP methods
ClosedPublic
Actions

Authored by epriestley on Mar 18 2014, 12:44 AM.

Tags

None

Referenced Files

	F13808753: D8559.diff
	Tue, Sep 17, 2:18 AM

	Unknown Object (File)
	Sat, Sep 14, 7:34 PM

	Unknown Object (File)
	Sat, Sep 14, 7:33 PM

	Unknown Object (File)
	Sat, Sep 14, 7:33 PM

	Unknown Object (File)
	Sat, Sep 14, 7:33 PM

	Unknown Object (File)
	Wed, Sep 4, 9:02 PM

	Unknown Object (File)
	Fri, Aug 30, 8:27 AM

	Unknown Object (File)
	Wed, Aug 28, 10:31 PM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan
dctrwatson

Commits

Restricted Diffusion Commit
rPa2a4f4b3da92: Fix validation of Harbormaster HTTP methods

Summary

Precedence here was mucked up.

Test Plan

Plan with no explicit "method" now defaults to POST correctly.

Diff Detail

Repository

rP Phabricator

Branch

httpmethodvalid

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

epriestley updated this revision to Diff 20311.Mar 18 2014, 12:44 AM

epriestley retitled this revision from to Fix validation of Harbormaster HTTP methods.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: dctrwatson, btrahan.

Herald added a subscriber: epriestley.Mar 18 2014, 12:44 AM

btrahan accepted this revision.Mar 18 2014, 1:46 AM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 18 2014, 1:46 AM

Closed by commit rPa2a4f4b3da92 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

step/

HarbormasterHTTPRequestBuildStepImplementation.php

16 lines

Diff 20311

View Options

src/applications/harbormaster/step/HarbormasterHTTPRequestBuildStepImplementation.php

Fix validation of Harbormaster HTTP methodsClosedPublicActions