Paths

Table of Contentst

Fix "Send an email to" Herald rule for Differential
ClosedPublic
Actions

Authored by epriestley on Mar 14 2014, 1:48 AM.

Tags

None

Referenced Files

	F13808227: D8527.diff
	Mon, Sep 16, 9:54 PM

	F13805391: D8527.diff
	Sun, Sep 15, 10:46 PM

	Unknown Object (File)
	Sat, Sep 14, 6:32 PM

	Unknown Object (File)
	Sat, Sep 14, 6:31 PM

	Unknown Object (File)
	Sat, Sep 14, 6:31 PM

	Unknown Object (File)
	Sat, Sep 14, 6:31 PM

	Unknown Object (File)
	Mon, Sep 9, 5:55 PM

	Unknown Object (File)
	Fri, Sep 6, 10:57 PM

View All Files

Subscribers

aran

epriestley

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rPb168ee116bd8: Fix "Send an email to" Herald rule for Differential

Summary

Herald returns a map of phid => true. This is unintuitive and should probably be cleaned up eventually.

Test Plan

With a "Send an email to" rule, updated a revision and saw no error in error log.

Diff Detail

Repository

rP Phabricator

Branch

err1

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

epriestley updated this revision to Diff 20233.Mar 14 2014, 1:48 AM

epriestley retitled this revision from to Fix "Send an email to" Herald rule for Differential.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added subscribers: epriestley, aran.Mar 14 2014, 1:48 AM

btrahan accepted this revision.Mar 14 2014, 5:35 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 14 2014, 5:35 PM

Closed by commit rPb168ee116bd8 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

3 lines

Diff 20233

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Fix "Send an email to" Herald rule for DifferentialClosedPublicActions