Page MenuHomePhabricator

Use "\z" instead of "$" to anchor validating regular expressions
ClosedPublic

Authored by epriestley on Mar 13 2014, 2:18 PM.
Tags
None
Referenced Files
F19103501: D8516.id.diff
Fri, Dec 5, 10:47 AM
F19007822: D8516.id20210.diff
Nov 21 2025, 8:38 PM
F19000049: D8516.id20210.diff
Nov 20 2025, 10:32 PM
F18958019: D8516.id.diff
Nov 13 2025, 3:47 AM
F18903097: D8516.id20210.diff
Nov 8 2025, 3:59 AM
F18903096: D8516.id20205.diff
Nov 8 2025, 3:59 AM
F18872581: D8516.diff
Nov 5 2025, 5:14 AM
F18827430: D8516.diff
Oct 24 2025, 10:03 AM
Subscribers

Details

Summary

Via HackerOne. In regular expressions, "$" matches "end of input, or before terminating newline". This means that the expression /^A$/ matches two strings: "A", and "A\n".

When we care about this, use \z instead, which matches "end of input" only.

This allowed registration of "username\n" and similar.

Test Plan
  • Grepped codebase for all calls to preg_match() / preg_match_all().
  • Fixed the ones where this seemed like it could have an impact.
  • Added and executed unit tests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Use "\z" instead of "$" to anchor validating regular expressions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 13 2014, 5:38 PM
epriestley updated this revision to Diff 20210.

Closed by commit rP969d0c3e8de2 (authored by @epriestley).