Page MenuHomePhabricator

Restore old "author can not be a reviewer" rule to Transactions
ClosedPublic

Authored by epriestley on Mar 12 2014, 12:11 AM.
Tags
None
Referenced Files
F14060025: D8496.diff
Sun, Nov 17, 11:02 PM
F14054400: D8496.id.diff
Sat, Nov 16, 1:07 AM
F14045943: D8496.diff
Wed, Nov 13, 4:34 PM
F14032830: D8496.diff
Sat, Nov 9, 3:55 PM
F14031459: D8496.id20161.diff
Sat, Nov 9, 10:37 AM
F14031180: D8496.id20161.diff
Sat, Nov 9, 9:42 AM
F14020917: D8496.diff
Wed, Nov 6, 3:43 AM
F14015330: D8496.id.diff
Sun, Nov 3, 5:37 PM
Subscribers

Details

Summary

This is a bit messy, but not tooo bad:

  • In general, stop the author from being added as a reviewer.
  • In the specific case that "self accept" is enabled, allow it. This is easier than trying to special case it.
  • When commandeering, we make the author a reviewer and make the actor the author, but these happen after validation. At validation time, it looks like we're making the author a reviewer. Just special case this.
  • Provide a slightly nicer message when trying to add yourself from arc. We hit the Transactions message anyway, but it's not formatted as cleanly.
  • Don't try to add the author via Herald.
Test Plan
  • Edited a revision with author = reviewer, got stopped.
  • Commandeered revision.
  • Updated from arc.
  • Updated in general.
  • Fired a "add author as reviewer" Herald rule without things breaking.

Diff Detail

Repository
rP Phabricator
Branch
diff3
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley retitled this revision from to Restore old "author can not be a reviewer" rule to Transactions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 12 2014, 1:02 AM
epriestley updated this revision to Diff 20161.

Closed by commit rP9e3baacc95c2 (authored by @epriestley).