Reject Phame domains which include a port number
ClosedPublic
Actions

Authored by epriestley on Mar 11 2014, 10:48 PM.

Tags

None

Referenced Files

	F14065757: D8493.diff
	Tue, Nov 19, 6:11 AM

	F14039132: D8493.id20151.diff
	Mon, Nov 11, 3:58 AM

	F14018481: D8493.id20151.diff
	Tue, Nov 5, 1:52 PM

	F13999980: D8493.diff
	Thu, Oct 24, 6:28 PM

	F13996882: D8493.id.diff
	Thu, Oct 24, 12:45 AM

	F13995765: D8493.id20154.diff
	Wed, Oct 23, 3:19 PM

	F13994092: D8493.id20151.diff
	Wed, Oct 23, 3:41 AM

	Unknown Object (File)
	Oct 3 2024, 1:50 AM

View All Files

Subscribers

aran

epriestley

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rPad88ff28a1b5: Reject Phame domains which include a port number

Summary

Via HackerOne. This doesn't actually have any security impact as far as we can tell, but a researcher reported it since it seems suspicious. At a minimum, it could be confusing. Also improve some i18n stuff.

Test Plan

Hit all the error cases, then saved a valid custom domain.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20151.Mar 11 2014, 10:48 PM

epriestley retitled this revision from to Reject Phame domains which include a port number.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added subscribers: epriestley, aran.Mar 11 2014, 10:48 PM

btrahan accepted this revision.Mar 11 2014, 10:49 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 11 2014, 10:49 PM

Closed by commit rPad88ff28a1b5 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

storage/

PhameBlog.php

31 lines

Diff 20154

View Options

src/applications/phame/storage/PhameBlog.php

Reject Phame domains which include a port numberClosedPublicActions