Reject Phame domains which include a port number
ClosedPublic
Actions

Authored by epriestley on Mar 11 2014, 10:48 PM.

Tags

None

Referenced Files

	F19044964: D8493.id.diff
	Thu, Nov 27, 5:37 AM

	F19038670: D8493.diff
	Nov 26 2025, 4:49 AM

	F19002730: D8493.id.diff
	Nov 21 2025, 6:40 AM

	F18897730: D8493.id20151.diff
	Nov 7 2025, 5:37 PM

	F18839495: D8493.id.diff
	Oct 27 2025, 4:59 PM

	F18836632: D8493.id20154.diff
	Oct 27 2025, 3:02 AM

	F18835086: D8493.id20151.diff
	Oct 26 2025, 1:16 PM

	F18826767: D8493.id.diff
	Oct 24 2025, 5:40 AM

View All Files

Subscribers

aran

epriestley

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rPad88ff28a1b5: Reject Phame domains which include a port number

Summary

Via HackerOne. This doesn't actually have any security impact as far as we can tell, but a researcher reported it since it seems suspicious. At a minimum, it could be confusing. Also improve some i18n stuff.

Test Plan

Hit all the error cases, then saved a valid custom domain.

Diff Detail

Repository

rP Phabricator

Branch

phamedomain

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

epriestley updated this revision to Diff 20151.Mar 11 2014, 10:48 PM

epriestley retitled this revision from to Reject Phame domains which include a port number.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added subscribers: epriestley, aran.Mar 11 2014, 10:48 PM

btrahan accepted this revision.Mar 11 2014, 10:49 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 11 2014, 10:49 PM

Closed by commit rPad88ff28a1b5 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

storage/

PhameBlog.php

31 lines

Diff 20151

View Options

src/applications/phame/storage/PhameBlog.php

Reject Phame domains which include a port numberClosedPublicActions