Page MenuHomePhabricator

Don't format "1/" as an ordered list in Remarkup
ClosedPublic

Authored by epriestley on Mar 11 2014, 8:39 PM.
Tags
None
Referenced Files
F15469556: D8489.diff
Fri, Apr 4, 2:34 PM
F15463128: D8489.diff
Tue, Apr 1, 8:37 PM
F15462920: D8489.id20138.diff
Tue, Apr 1, 6:57 PM
F15462526: D8489.id.diff
Tue, Apr 1, 3:40 PM
F15462324: D8489.id20137.diff
Tue, Apr 1, 2:01 PM
F15459694: D8489.id20138.diff
Mon, Mar 31, 3:15 PM
F15458542: D8489.diff
Mon, Mar 31, 4:34 AM
F15456665: D8489.diff
Sun, Mar 30, 11:10 AM
Subscribers

Details

Summary

See https://www.facebook.com/dreiss/posts/10152231659206208. I added this "bizarre Facebook-ism" to the set of ordered list characters in T3797, but apparently the intent of these "1/" lists is to avoid automatic formatting. I don't fully understand any part of this, but this list style is used only at Facebook, and automatically formatting these lists enjoys little support there (25 against, 2 for, 29 neutral).

Test Plan

Updated and executed unit tests.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Don't format "1/" as an ordered list in Remarkup.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: dreiss, btrahan, chad.
dreiss edited edge metadata.

Yay democracy!

itsawesome

This revision is now accepted and ready to land.Mar 11 2014, 8:42 PM
epriestley updated this revision to Diff 20138.

Closed by commit rPHU6b1066f7c0b3 (authored by @epriestley).