Page MenuHomePhabricator

Don't prefill "add email address" from GET
ClosedPublic

Authored by epriestley on Mar 8 2014, 8:35 PM.
Tags
None
Referenced Files
F13999933: D8458.id20063.diff
Thu, Oct 24, 6:07 PM
F13998868: D8458.diff
Thu, Oct 24, 11:35 AM
F13977915: D8458.id.diff
Fri, Oct 18, 8:36 PM
Unknown Object (File)
Oct 2 2024, 5:37 AM
Unknown Object (File)
Sep 19 2024, 7:20 PM
Unknown Object (File)
Sep 11 2024, 8:29 PM
Unknown Object (File)
Aug 30 2024, 4:29 PM
Unknown Object (File)
Aug 26 2024, 8:09 AM
Subscribers

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP761b66228371: Don't prefill "add email address" from GET
Summary

Via HackerOne. I don't think this is a security vulnerability, but it is inconsistent. There's no reason to prefill this, and I think the code was just lazy.

Test Plan
  • Hit this page with ?email=xyz in a GET request, no more prefill.
  • Looped the page with bad addresses, appropriate prefill.
  • Added an address.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 10 2014, 4:58 PM
epriestley updated this revision to Diff 20105.

Closed by commit rP761b66228371 (authored by @epriestley).