Page MenuHomePhabricator

Don't prefill "add email address" from GET
ClosedPublic

Authored by epriestley on Mar 8 2014, 8:35 PM.
Tags
None
Referenced Files
F15410798: D8458.diff
Wed, Mar 19, 8:26 AM
F15405563: D8458.id20105.diff
Tue, Mar 18, 11:38 AM
F15381967: D8458.id20063.diff
Fri, Mar 14, 10:08 AM
Unknown Object (File)
Fri, Feb 21, 12:24 PM
Unknown Object (File)
Feb 15 2025, 10:47 PM
Unknown Object (File)
Jan 25 2025, 4:50 PM
Unknown Object (File)
Jan 18 2025, 1:53 PM
Unknown Object (File)
Jan 17 2025, 10:35 PM
Subscribers

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP761b66228371: Don't prefill "add email address" from GET
Summary

Via HackerOne. I don't think this is a security vulnerability, but it is inconsistent. There's no reason to prefill this, and I think the code was just lazy.

Test Plan
  • Hit this page with ?email=xyz in a GET request, no more prefill.
  • Looped the page with bad addresses, appropriate prefill.
  • Added an address.

Diff Detail

Repository
rP Phabricator
Branch
noprefill
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 10 2014, 4:58 PM
epriestley updated this revision to Diff 20105.

Closed by commit rP761b66228371 (authored by @epriestley).