Page MenuHomePhabricator

Fix calendar display on profile.
ClosedPublic

Authored by btrahan on Feb 25 2014, 9:38 PM.
Tags
None
Referenced Files
F14415791: D8341.id19833.diff
Tue, Dec 24, 7:07 PM
F14415773: D8341.id19834.diff
Tue, Dec 24, 7:04 PM
Unknown Object (File)
Fri, Dec 6, 6:35 PM
Unknown Object (File)
Fri, Nov 29, 1:57 AM
Unknown Object (File)
Fri, Nov 29, 1:57 AM
Unknown Object (File)
Nov 25 2024, 6:01 AM
Unknown Object (File)
Nov 20 2024, 10:33 PM
Unknown Object (File)
Nov 16 2024, 10:07 PM

Details

Reviewers
epriestley
chad
Commits
Restricted Diffusion Commit
rPb1e44239ba11: Fix calendar display on profile.
Summary

...maybe anyway because I can't reproduce it live. This diff does two things that should help with bugginess though - uses $viewer rather than $user (...$user is who we are looking at...) *AND* upgrades a Conpherence util class to Calendar, and said util class has unit tests and came about from fixing a similar bug in Conpherence back in the day.

Wrote some comments in the util class because I think it has a tendency to trip people up. These comments are not partciularly good however.

Test Plan

viewed user profile - looked good. viewed conpherence - looked good. ran unit tests - they passed. (note I would also like to push this live and verify Chad's profile is fixed on secure.phabricator.com)

Diff Detail

Repository
rP Phabricator
Branch
fixcal
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

...well, this seems to have gone horribly wrong now that I pushed it live. :) Expect another diff soon.