Page MenuHomePhabricator

Require a CSRF code for Twitter and JIRA (OAuth 1) logins
ClosedPublic

Authored by epriestley on Feb 23 2014, 11:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 17, 7:38 PM
Unknown Object (File)
Fri, Jan 17, 2:21 AM
Unknown Object (File)
Tue, Jan 14, 10:56 PM
Unknown Object (File)
Sat, Jan 11, 11:21 PM
Unknown Object (File)
Sat, Jan 11, 4:19 AM
Unknown Object (File)
Tue, Dec 24, 8:27 AM
Unknown Object (File)
Dec 20 2024, 5:57 AM
Unknown Object (File)
Dec 12 2024, 10:02 AM
Subscribers

Details

Summary

OAuth1 doesn't have anything like the state parameter, and I overlooked that we need to shove one in there somewhere. Append it to the callback URI. This functions like state in OAuth2.

Without this, an attacker can trick a user into logging into Phabricator with an account the attacker controls.

Test Plan
  • Logged in with JIRA.
  • Logged in with Twitter.
  • Logged in with Facebook (an OAuth2 provider).
  • Linked a Twitter account.
  • Linked a Facebook account.
  • Jiggered codes in URIs and verified that I got the exceptions I expected.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Feb 23 2014, 11:20 PM
  • Restore the check for an empty 'code' parameter for OAuth2.