Reject nonminmal representations of UTF8 at the beginning of the 3-byte BMP range
ClosedPublic
Actions

Authored by epriestley on Feb 23 2014, 8:35 PM.

Tags

None

Referenced Files

	F15413350: D8313.id19764.diff
	Wed, Mar 19, 6:13 PM

	F15413190: D8313.diff
	Wed, Mar 19, 5:24 PM

	F15410876: D8313.diff
	Wed, Mar 19, 8:37 AM

	F15410455: D8313.id19779.diff
	Wed, Mar 19, 7:25 AM

	F15410171: D8313.diff
	Wed, Mar 19, 6:51 AM

	F15384461: D8313.id19779.diff
	Fri, Mar 14, 7:58 PM

	F15334297: D8313.diff
	Sat, Mar 8, 8:06 AM

	Unknown Object (File)
	Mon, Feb 24, 11:31 AM

Subscribers

Details

Reviewers

arice
btrahan

Maniphest Tasks

T1191: Comments are truncated at first non-base-plane character

Commits

rPHU563e600eba85: Reject nonminmal representations of UTF8 at the beginning of the 3-byte BMP…

Summary

Ref T1191. These byte ranges (\xE0\x80\x80 through \xE0\x9F\xBF) are alternate representations of characters with a different preferred minimal representation. MySQL and mbstring both reject them, and we should too.

Test Plan

Ran unit tests.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

arice accepted this revision.Feb 23 2014, 11:15 PM

arice added inline comments.

src/utils/utf8.php
126	*like

epriestley added inline comments.Feb 23 2014, 11:17 PM

src/utils/utf8.php
126	o why thank you

"lik" -> "like"

Closed by commit rPHU563e600eba85 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

utils/

__tests__/

PhutilUTF8TestCase.php

2 lines

utf8.php

21 lines

Diff 19779

View Options

src/utils/tests/PhutilUTF8TestCase.php

View Options

Reject nonminmal representations of UTF8 at the beginning of the 3-byte BMP rangeClosedPublicActions