Page MenuHomePhabricator

Add AWS Region support to PhutilAWSFuture.
ClosedPublic

Authored by seporaitis on Feb 23 2014, 8:05 PM.
Tags
None
Referenced Files
F15264088: D8311.id19762.diff
Tue, Feb 25, 5:59 PM
Unknown Object (File)
Mon, Feb 24, 11:31 AM
Unknown Object (File)
Sun, Feb 2, 5:31 AM
Unknown Object (File)
Thu, Jan 30, 4:49 AM
Unknown Object (File)
Dec 31 2024, 4:16 AM
Unknown Object (File)
Dec 10 2024, 6:59 AM
Unknown Object (File)
Nov 30 2024, 9:43 PM
Unknown Object (File)
Nov 27 2024, 9:30 PM

Details

Summary

Almost all AWS services endpoints follow this structure: SERVICE_NAME.REGION_ID.amazonaws.com. This revision adds support for setting a region in PhutilAWSFuture.

There are couple of exceptions to above rule - some services do not have region in their endpoint url (DevPay, Route 53, IAM, Import/Export, Security Token Service), some have a single endpoint in one region (OpsWorks, Support), some are funky (S3), but they all can be covered by overriding getHost() method.

Test Plan

No tests added. I acked through three repositories (libphutil, arcanist & phabricator) and couldn't find AWS used anywhere.

Diff Detail

Branch
master
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

I think this is only used in some Drydock code that's sitting half-finished somewhere.