Move raw file download icon to file box in Diffusion
ClosedPublic
Actions

Authored by chad on Feb 21 2014, 11:18 PM.

Tags

None

Referenced Files

	F13813689: D8302.id19750.diff
	Thu, Sep 19, 12:14 AM

	F13813640: D8302.id19748.diff
	Thu, Sep 19, 12:00 AM

	F13813482: D8302.id19749.diff
	Wed, Sep 18, 11:21 PM

	Unknown Object (File)
	Mon, Sep 16, 12:19 PM

	Unknown Object (File)
	Fri, Sep 13, 11:06 PM

	Unknown Object (File)
	Fri, Sep 13, 11:04 PM

	Unknown Object (File)
	Fri, Sep 13, 11:04 PM

	Unknown Object (File)
	Fri, Sep 13, 11:04 PM

Subscribers

Details

Reviewers

epriestley

Maniphest Tasks

T4467: Minimize actionlist in Diffusion Browse View

Commits

Restricted Diffusion Commit
rP8662b27f89c6: Move raw file download icon to file box in Diffusion

Summary

For images and text, show the "Raw" buttons on the file's ObjectBox

Test Plan

View an image and a text file in Diffusion, click on the download link in each.

Diff Detail

Repository

rP Phabricator

Branch

raw-icon

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

Oops

{F116383}

{F116385}

It looks like binary, non-image files have some sketchiness. Here's an example:

https://secure.phabricator.com/diffusion/P/browse/master/webroot/rsrc/swf/aphlict.swf

Closed by commit rP8662b27f89c6 (authored by @chad).

good catch, will hit you up with another diff here

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBrowseFileController.php

62 lines

Diff 19748

View Options

src/applications/diffusion/controller/DiffusionBrowseFileController.php

Move raw file download icon to file box in DiffusionClosedPublicActions