Fix (?) an issue with CCs not being written into commit messages properly
ClosedPublic
Actions

Authored by epriestley on Feb 21 2014, 8:17 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 29, 10:33 PM

	Unknown Object (File)
	Sun, Dec 29, 10:27 PM

	Unknown Object (File)
	Sun, Dec 29, 10:24 PM

	Unknown Object (File)
	Thu, Dec 26, 10:36 PM

	Unknown Object (File)
	Thu, Dec 26, 9:39 AM

	Unknown Object (File)
	Tue, Dec 24, 11:26 AM

	Unknown Object (File)
	Dec 13 2024, 12:18 PM

	Unknown Object (File)
	Dec 11 2024, 9:11 PM

View All Files

Subscribers

aran

zeeg

Details

Reviewers

zeeg
btrahan

Commits

Restricted Diffusion Commit
rPa84cc1ab731a: Fix (?) an issue with CCs not being written into commit messages properly

Summary

Report from @zeeg, I think this is the root issue. Currently, if a project is CC'd we'll write "CC: projectname", but should write "CC: #projectname".

Test Plan

Verified that we now write "CC: #projectname".

Diff Detail

Repository

rP Phabricator

Branch

projcc

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

btrahan accepted this revision.Feb 21 2014, 8:24 PM

lgtm

noidea

Closed by commit rPa84cc1ab731a (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

field/

specification/

DifferentialCCsFieldSpecification.php

2 lines

DifferentialReviewersFieldSpecification.php

2 lines

Diff 19734

View Options

src/applications/differential/field/specification/DifferentialCCsFieldSpecification.php