Page MenuHomePhabricator

Support "only the first time" in Maniphest
ClosedPublic

Authored by epriestley on Feb 11 2014, 12:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 9:54 AM
Unknown Object (File)
Fri, Jan 24, 5:32 AM
Unknown Object (File)
Thu, Jan 23, 9:49 PM
Unknown Object (File)
Thu, Jan 23, 9:49 PM
Unknown Object (File)
Thu, Jan 23, 9:49 PM
Unknown Object (File)
Wed, Jan 22, 12:25 PM
Unknown Object (File)
Fri, Jan 17, 8:16 PM
Unknown Object (File)
Fri, Jan 17, 10:27 AM
Subscribers
Tokens
"Love" token, awarded by dctrwatson.

Details

Summary

Ref T4403. Implements "only the first time" for Maniphest rules, and fixes the trigger itself.

The trigger would never fire and block rules because it was comparing a string (like "first") to an int (like 0).

The "only" vs "every" stuff is contributed and I should have pushed back harder on this toInt / toString stuff. Maybe I'll just get rid of it; it purely causes confusion and problems.

Test Plan

Wrote an "only the first time" rule, ran it twice, it applied once.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped