we were calling a member method on a diffusion hash. not sure why. Fixes T4402
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T4402: "Skip Past This Commit" returns fatal error calling getCommitIdentifier() on a non-object
- Commits
- Restricted Diffusion Commit
rP8739ea4dc103: Diffusion - fix browse file bug
clicked about, no fatals and seemed to move sensical backwards in time
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- diffbug
- Lint
Lint Passed - Unit
No Test Coverage
Event Timeline
Comment Actions
Oh, I think diffusion.commitparentsquery previously had some magic which wouldn't have survived real calls over the wire. D7808 fixed that to make it return identifiers instead, but I missed this callsite. Thanks!