Page MenuHomePhabricator

Rebuild custom field indexes when rebuilding standard/fulltext search indexes
ClosedPublic

Authored by epriestley on Feb 10 2014, 9:33 PM.
Tags
None
Referenced Files
F13198715: D8185.id.diff
Mon, May 13, 9:14 AM
F13183984: D8185.id18509.diff
Fri, May 10, 1:50 PM
F13181188: D8185.id18526.diff
Thu, May 9, 9:37 AM
F13181187: D8185.id18509.diff
Thu, May 9, 9:37 AM
F13181118: D8185.id.diff
Thu, May 9, 8:48 AM
F13181103: D8185.diff
Thu, May 9, 8:39 AM
Unknown Object (File)
Tue, May 7, 8:07 AM
Unknown Object (File)
Sat, Apr 27, 11:33 PM
Subscribers

Details

Summary

Ref T4379. Fixes T4359. Currently, bin/search index does not rebuild CustomField indexes. This is because they aren't really part of the main search index. However, from a user's point of view this is by far the most logical place to look for index rebuilds, and it's straightforward for us to write into this secondary store.

At some point, it might be nice to let you specify fields as "fulltext" too, although no one has asked for that yet. We could then dump the text of those fields into the fulltext index. Ref T418.

Test Plan

Used bin/search index --type proj --trace, etc., and examination of the database to verify that indexes rebuilt. Reindexed users, tasks, projects.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped