Page MenuHomePhabricator

When creating foreign stubs during SVN import, mark them imported
ClosedPublic

Authored by epriestley on Feb 3 2014, 5:04 PM.
Tags
None
Referenced Files
F15336522: D8133.diff
Sat, Mar 8, 7:19 PM
F15286338: D8133.id18393.diff
Tue, Mar 4, 7:17 PM
Unknown Object (File)
Mon, Feb 24, 11:27 AM
Unknown Object (File)
Sun, Feb 23, 10:20 PM
Unknown Object (File)
Jan 28 2025, 12:27 AM
Unknown Object (File)
Jan 27 2025, 11:03 AM
Unknown Object (File)
Jan 16 2025, 5:33 AM
Unknown Object (File)
Dec 27 2024, 1:04 AM
Subscribers

Details

Summary

See https://github.com/facebook/phabricator/issues/501. I think the issue here is that we created a foreign stub for commit X-1, probably because commit X was created by running svn cp y x.

Test Plan

I'll write a separate test for this before I land it. Huge pain to test.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bummer on the test pain :/

Yeah -- it's not the end of the world, it just took 30 seconds to write this and is going to take 20 minutes to write a test for.

epriestley updated this revision to Unknown Object (????).Feb 3 2014, 8:20 PM
  • Yep, spent like 20 minutes writing a test case for this.