Page MenuHomePhabricator

When creating foreign stubs during SVN import, mark them imported
ClosedPublic

Authored by epriestley on Feb 3 2014, 5:04 PM.
Tags
None
Referenced Files
F20878946: D8133.id18401.diff
Fri, Jun 26, 12:22 PM
F20878792: D8133.diff
Fri, Jun 26, 12:20 PM
F20874532: D8133.id18400.diff
Fri, Jun 26, 11:15 AM
F20874528: D8133.id18393.diff
Fri, Jun 26, 11:15 AM
Unknown Object (File)
Sun, Jun 7, 1:32 AM
Unknown Object (File)
Apr 16 2026, 1:09 AM
Unknown Object (File)
Mar 24 2026, 2:17 AM
Unknown Object (File)
Mar 14 2026, 5:06 PM
Subscribers

Details

Summary

See https://github.com/facebook/phabricator/issues/501. I think the issue here is that we created a foreign stub for commit X-1, probably because commit X was created by running svn cp y x.

Test Plan

I'll write a separate test for this before I land it. Huge pain to test.

Diff Detail

Repository
rP Phabricator
Branch
foreignflag
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

bummer on the test pain :/

Yeah -- it's not the end of the world, it just took 30 seconds to write this and is going to take 20 minutes to write a test for.

epriestley updated this revision to Unknown Object (????).Feb 3 2014, 8:20 PM
  • Yep, spent like 20 minutes writing a test case for this.