Page MenuHomePhabricator

Distinguish between "Remote URI" and "Clone URI" in Repositories
ClosedPublic

Authored by epriestley on Jan 29 2014, 8:35 PM.
Tags
None
Referenced Files
F14491195: D8096.id18345.diff
Thu, Jan 2, 5:10 AM
F14490896: D8096.id18317.diff
Thu, Jan 2, 3:42 AM
Unknown Object (File)
Mon, Dec 30, 11:13 PM
Unknown Object (File)
Mon, Dec 30, 7:29 AM
Unknown Object (File)
Mon, Dec 30, 5:43 AM
Unknown Object (File)
Fri, Dec 13, 8:15 AM
Unknown Object (File)
Thu, Dec 12, 6:17 PM
Unknown Object (File)
Thu, Dec 12, 3:33 AM
Subscribers
Tokens
"The World Burns" token, awarded by zeeg."Love" token, awarded by dctrwatson.

Details

Summary

Hosted repositories have muddied this distinction somewhat. In some cases, we only want to use the real remote URI, and the call is only relevant for imported repositories.

In other cases, we want the URI we'd plug into git clone.

Move this logic into PhabricatorRepository and make the distinction more clear.

Test Plan

Viewed SVN, Git, and Mercurial hosted and remote repositories, all the URIs looked reasonable.

Diff Detail

Repository
rP Phabricator
Branch
ruri1
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley updated this revision to Unknown Object (????).Jan 29 2014, 8:45 PM
  • Don't strip username from hosted SSH repositories.