Page MenuHomePhabricator

Legalpad - style NOTE IMPORTANT WARNING remarkup slightly differently
ClosedPublic

Authored by btrahan on Jan 24 2014, 8:41 PM.
Tags
None
Referenced Files
F14034942: D8060.id18240.diff
Sun, Nov 10, 3:05 AM
F14034773: D8060.id18239.diff
Sun, Nov 10, 2:06 AM
F14034729: D8060.id18238.diff
Sun, Nov 10, 1:57 AM
F13963419: D8060.diff
Tue, Oct 15, 3:47 PM
Unknown Object (File)
Oct 11 2024, 3:59 PM
Unknown Object (File)
Oct 11 2024, 3:58 PM
Unknown Object (File)
Oct 11 2024, 3:58 PM
Unknown Object (File)
Oct 7 2024, 1:22 PM

Details

Reviewers
epriestley
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPf6e9d36c329c: Legalpad - style NOTE IMPORTANT WARNING remarkup slightly differently
Summary

round them there corners, to create more of a "bubble" effect in legalpad. Ref T3116.

Test Plan

see screenshot, which demonstrates new style works

Diff Detail

Branch
legalstyles
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

src/applications/legalpad/controller/LegalpadDocumentSignController.php
207–213

I feel like we changed this (or maybe it was javelin includes?) but I can't remember the details.

These should probably be px -- I think the em stuff is mostly old crazy @epriestley leftovers.

(@chad, feel free to yell at us.)

src/applications/legalpad/controller/LegalpadDocumentSignController.php
207–213

Oh, right -- there should be a $this->requireResource(...) now I think.

btrahan updated this revision to Unknown Object (????).Jan 24 2014, 8:45 PM

...i remembered!

require_celerity_resource => $this->requireResource in controllers...

I totally forgot until you made the comment. :P

btrahan updated this revision to Unknown Object (????).Jan 24 2014, 8:47 PM

...and switched to pixels. also made it a little curvier for maximum "bubble-look" for one-line NOTEs

I like px divisible by 4 and 3px on corners. doctordance

webroot/rsrc/css/application/legalpad/legalpad-document.css
18

btw, don't need to do -moz-border-radius, it's been unused just border-radius 22 versions.

http://caniuse.com/border-radius