Don't let Diffusion show that an importing repository is "100%" imported
ClosedPublic
Actions

Authored by epriestley on Jan 24 2014, 7:05 PM.

Tags

None

Referenced Files

	F14381235: D8058.id18233.diff
	Sat, Dec 21, 4:48 AM

	F14379315: D8058.diff
	Sat, Dec 21, 2:45 AM

	Unknown Object (File)
	Sun, Dec 15, 5:58 PM

	Unknown Object (File)
	Sun, Dec 15, 5:58 PM

	Unknown Object (File)
	Sun, Dec 15, 5:27 PM

	Unknown Object (File)
	Sun, Dec 15, 5:27 PM

	Unknown Object (File)
	Sat, Dec 7, 12:40 PM

	Unknown Object (File)
	Wed, Dec 4, 12:24 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP53687827c643: Don't let Diffusion show that an importing repository is "100%" imported

Summary

A few users have hit this and found it confusing. Currently, it means "more than 99.95%", which is very different from "100%". Instead:

show an extra digit of precision; and
cap the display at "99.99%", so it's more clear that work is still happening.

Test Plan

Faked it and saw it cap at 99.99%.

Diff Detail

Branch

percents

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

btrahan accepted this revision.Jan 24 2014, 7:24 PM

Closed by commit rP53687827c643 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionRepositoryEditMainController.php

8 lines

Diff 18233

View Options

src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php

Don't let Diffusion show that an importing repository is "100%" importedClosedPublicActions