Page MenuHomePhabricator
Differential D8016

Add basic test coverage for the Subversion parser
ClosedPublic
Actions

Authored by epriestley on Jan 20 2014, 9:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 3, 9:23 PM
Unknown Object (File)
Mon, Feb 3, 8:01 PM
Unknown Object (File)
Thu, Jan 30, 8:16 AM
Unknown Object (File)
Wed, Jan 29, 2:52 PM
Unknown Object (File)
Mon, Jan 27, 2:54 AM
Unknown Object (File)
Thu, Jan 23, 4:00 AM
Unknown Object (File)
Tue, Jan 21, 8:52 AM
Unknown Object (File)
Mon, Jan 20, 2:16 PM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T4327: Problems trying to import project
Commits
Restricted Diffusion Commit
rPdc74da0abed3: Add basic test coverage for the Subversion parser
Summary

Ref T4327. Adds the same basic battery of tests to the SVN parser as the other parsers have.

___________________________ < THIS IS AN AMAZING DIFF > --------------------------- \ ^__^ \ (oo)\_______ (__)\ )\/\ ||----w | || ||
Test Plan

Ran unit tests against SVN change parsing.

bwahaha

Diff Detail

Branch
cparser4
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/repository/worker/__tests__/PhabricatorChangeParserTestCase.php:445XHP16TODO Comment
Unit
Tests Passed

Event Timeline

epriestley updated this revision to Unknown Object (????).Jan 20 2014, 9:33 PM
  • Make the SVN TODO about symlinks slightly more accurate.
btrahan accepted this revision.Jan 20 2014, 9:41 PM

AMAZEBALLS

epriestley closed this revision.Jan 21 2014, 1:25 AM

Closed by commit rPdc74da0abed3 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
engine/
__tests__/
data/
worker/
__tests__/
198 lines
commitchangeparser/
85 lines

Diff 18134

View Options

src/applications/repository/engine/__tests__/data/CHC.svn.tgz

Loading...
View Options

src/applications/repository/worker/__tests__/PhabricatorChangeParserTestCase.php

Loading...
View Options

src/applications/repository/worker/commitchangeparser/PhabricatorRepositorySvnCommitChangeParserWorker.php

Loading...
Phabricator · Built by Phacility