Add unit tests for Git change parsers
ClosedPublic
Actions

Authored by epriestley on Jan 20 2014, 7:50 PM.

Tags

None

Referenced Files

	F15473736: D8012.id18123.diff
	Sun, Apr 6, 1:25 AM

	F15470241: D8012.id18131.diff
	Fri, Apr 4, 9:23 PM

	F15462370: D8012.id18131.diff
	Tue, Apr 1, 2:36 PM

	F15450882: D8012.id18131.diff
	Fri, Mar 28, 6:47 PM

	F15433783: D8012.id18131.diff
	Tue, Mar 25, 12:36 AM

	F15427606: D8012.id18131.diff
	Sun, Mar 23, 3:10 PM

	F15422128: D8012.id18123.diff
	Sat, Mar 22, 5:47 AM

	F15403718: D8012.id.diff
	Tue, Mar 18, 4:37 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4327: Problems trying to import project

Commits

Restricted Diffusion Commit
rPf63e7571e525: Add unit tests for Git change parsers

Summary

Ref T4327. Adds some basic tests to the Git parser for a set of common operations (add, change, move, copy, directory, symlink, propchange).

Test Plan

Ran unit tests.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley added inline comments.Jan 20 2014, 7:51 PM

src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryGitCommitChangeParserWorker.php
231–249	The actual SQL code deals with all this type massaging, so we can use a simpler implementation here.

btrahan accepted this revision.Jan 20 2014, 9:04 PM

Closed by commit rPf63e7571e525 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

repository/

engine/

__tests__/

PhabricatorWorkingCopyTestCase.php

11 lines

data/

CHA.git.tgz

worker/

__tests__/

PhabricatorChangeParserTestCase.php

275 lines

commitchangeparser/

PhabricatorRepositoryCommitChangeParserWorker.php

6 lines

PhabricatorRepositoryGitCommitChangeParserWorker.php

21 lines

Diff 18131

View Options

src/__phutil_library_map__.php

View Options

src/applications/repository/engine/tests/PhabricatorWorkingCopyTestCase.php

View Options

src/applications/repository/engine/tests/data/CHA.git.tgz

View Options

src/applications/repository/worker/tests/PhabricatorChangeParserTestCase.php

View Options

src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryCommitChangeParserWorker.php

View Options

src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryGitCommitChangeParserWorker.php

Add unit tests for Git change parsersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 18131

src/__phutil_library_map__.php

src/applications/repository/engine/__tests__/PhabricatorWorkingCopyTestCase.php

src/applications/repository/engine/__tests__/data/CHA.git.tgz

src/applications/repository/worker/__tests__/PhabricatorChangeParserTestCase.php

src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryCommitChangeParserWorker.php

src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryGitCommitChangeParserWorker.php

Add unit tests for Git change parsers
ClosedPublic
Actions

Revision Contents
Changeset List

src/applications/repository/engine/tests/PhabricatorWorkingCopyTestCase.php

src/applications/repository/engine/tests/data/CHA.git.tgz

src/applications/repository/worker/tests/PhabricatorChangeParserTestCase.php