Page MenuHomePhabricator
Differential D7997

Move more discovery responsibilities into DiscoveryEngine
ClosedPublic
Actions

Authored by epriestley on Jan 17 2014, 9:27 PM.
Tags
None
Referenced Files
F14106634: D7997.diff
Wed, Nov 27, 6:20 AM
Unknown Object (File)
Sat, Nov 23, 4:45 PM
Unknown Object (File)
Wed, Nov 20, 8:43 PM
Unknown Object (File)
Sun, Nov 17, 12:27 AM
Unknown Object (File)
Wed, Nov 6, 12:36 AM
Unknown Object (File)
Wed, Nov 6, 12:36 AM
Unknown Object (File)
Wed, Nov 6, 12:36 AM
Unknown Object (File)
Mon, Nov 4, 10:53 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T4327: Problems trying to import project
Commits
Restricted Diffusion Commit
rP8520d9e07068: Move more discovery responsibilities into DiscoveryEngine
Summary

Ref T4327. This moves the last pieces of discovery responsibility out of the PullLocal daemon and into the DiscoveryEngine.

(This makes it easier to discover repositories in unit tests in the future, since we don't need to build a PullLocal daemon and can just build a DiscoveryEngine.)

Test Plan

Ran phd debug pulllocal. Ran repostory discover.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley added inline comments.Jan 17 2014, 9:42 PM
src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php
61

This indirectly fixes a small potential bug, where a commit could get marked in the cache but not actually recorded.

btrahan accepted this revision.Jan 17 2014, 9:57 PM

Sweet,

epriestley closed this revision.Jan 18 2014, 12:09 AM

Closed by commit rP8520d9e07068 (authored by @epriestley).

Revision Contents
Changeset List

Diff 18106

View Options

src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementDiscoverWorkflow.php

Loading...
Phabricator · Built by Phacility