Page MenuHomePhabricator

Perform search indexing in the worker queue and respect `bin/search index --background`
ClosedPublic

Authored by epriestley on Jan 14 2014, 8:31 PM.
Tags
None
Referenced Files
F14396273: D7966.diff
Sun, Dec 22, 7:04 AM
Unknown Object (File)
Sat, Dec 14, 2:51 AM
Unknown Object (File)
Thu, Dec 12, 6:31 AM
Unknown Object (File)
Tue, Dec 10, 8:35 PM
Unknown Object (File)
Sat, Dec 7, 9:09 PM
Unknown Object (File)
Wed, Dec 4, 3:16 AM
Unknown Object (File)
Sat, Nov 30, 1:54 PM
Unknown Object (File)
Tue, Nov 26, 1:55 PM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPa716fe99f3b2: Perform search indexing in the worker queue and respect `bin/search index…
Summary

Fixes T3857. Earlier work made this trivial and just left product questions, which I've answered by requiring the daemons to run on reasonable installs.

Test Plan

Ran bin/search index and bin/search index --background. Observed indexes write in the former case and tasks queue in the latter case. Commented with a unique string on a revision and searched for it a moment later, got exactly one result (that revision), verifying that reindexing works correctly.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.
src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php
32

the it sentence is hard to read

epriestley updated this revision to Unknown Object (????).Jan 14 2014, 9:22 PM
  • Make it the it easier to read it.