Page MenuHomePhabricator

Extend all "ManagementWorkflow" classes from a base class
ClosedPublic

Authored by epriestley on Dec 26 2013, 9:39 PM.
Tags
None
Referenced Files
F14383899: D7838.id17750.diff
Sat, Dec 21, 9:46 AM
F14383319: D7838.diff
Sat, Dec 21, 6:56 AM
Unknown Object (File)
Tue, Dec 17, 7:50 PM
Unknown Object (File)
Sun, Dec 15, 12:37 AM
Unknown Object (File)
Sat, Dec 14, 8:29 PM
Unknown Object (File)
Sat, Dec 14, 2:57 PM
Unknown Object (File)
Sat, Dec 14, 11:49 AM
Unknown Object (File)
Fri, Dec 6, 4:46 PM
Subscribers

Details

Summary

Ref T2015. Not directly related to Drydock, but I've wanted to do this for a bit.

Introduce a common base class for all the workflows in the scripts in bin/*. This slightly reduces code duplication by moving isExecutable() to the base, but also provides getViewer(). This is a little nicer than PhabricatorUser::getOmnipotentUser() and gives us a layer of indirection if we ever want to introduce more general viewer mechanisms in scripts.

Test Plan

Lint; ran some of the scripts.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped