Page MenuHomePhabricator

Extend all "ManagementWorkflow" classes from a base class
ClosedPublic

Authored by epriestley on Dec 26 2013, 9:39 PM.
Tags
None
Referenced Files
F22745904: D7838.id17750.diff
Sun, Oct 4, 5:05 PM
F22745903: D7838.id17731.diff
Sun, Oct 4, 5:05 PM
F22744978: D7838.diff
Sun, Oct 4, 4:27 PM
Unknown Object (File)
Jul 30 2026, 3:27 AM
Unknown Object (File)
Jul 2 2026, 2:13 AM
Unknown Object (File)
Jul 2 2026, 2:10 AM
Unknown Object (File)
Jun 22 2026, 7:45 PM
Unknown Object (File)
Jun 10 2026, 12:57 AM
Subscribers

Details

Summary

Ref T2015. Not directly related to Drydock, but I've wanted to do this for a bit.

Introduce a common base class for all the workflows in the scripts in bin/*. This slightly reduces code duplication by moving isExecutable() to the base, but also provides getViewer(). This is a little nicer than PhabricatorUser::getOmnipotentUser() and gives us a layer of indirection if we ever want to introduce more general viewer mechanisms in scripts.

Test Plan

Lint; ran some of the scripts.

Diff Detail

Branch
ddock4
Lint
Lint Passed
Unit
Tests Passed