Page MenuHomePhabricator
Differential D7820

Add a "branches" rule for Herald commit rules
ClosedPublic
Actions

Authored by epriestley on Dec 23 2013, 7:16 PM.
Tags
None
Referenced Files
F13264876: D7820.id.diff
Mon, May 27, 10:56 PM
F13262495: D7820.diff
Mon, May 27, 2:11 AM
F13245800: D7820.diff
Thu, May 23, 6:15 AM
F13236313: D7820.id17707.diff
Tue, May 21, 9:09 AM
F13224054: D7820.diff
Sun, May 19, 6:06 AM
F13209345: D7820.id17696.diff
Thu, May 16, 11:33 PM
F13178812: D7820.diff
Wed, May 8, 8:42 PM
Unknown Object (File)
May 1 2024, 9:11 PM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T4195: Implement pre-commit Herald rules
Commits
Restricted Diffusion Commit
rPadcc4ee1db1d: Add a "branches" rule for Herald commit rules
Summary

Fixes T4195. Allows you to write a rule against a commit's branches.

This completes outstanding work on T4195.

Test Plan

Pushed to Git and Mercurial repositories and verified branches were selected correctly by examining transcripts.

Diff Detail

Branch
hbranch1
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

epriestley added inline comments.Dec 23 2013, 7:17 PM
src/applications/diffusion/engine/DiffusionCommitHookEngine.php
431

This fixes a bug where we could update the wrong ref when a push includes multiple branches.

btrahan accepted this revision.Dec 26 2013, 6:22 PM
epriestley closed this revision.Dec 26 2013, 6:40 PM

Closed by commit rPadcc4ee1db1d (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
engine/
29 lines
herald/
7 lines
herald/
adapter/
3 lines

Diff 17696

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...
View Options

src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
Phabricator · Built by Phacility