Page MenuHomePhabricator

Assign PHIDs to PushLogs
ClosedPublic

Authored by epriestley on Dec 17 2013, 8:36 PM.
Tags
None
Referenced Files
F14129338: D7780.id17606.diff
Sun, Dec 1, 11:06 AM
Unknown Object (File)
Sat, Nov 30, 9:04 AM
Unknown Object (File)
Tue, Nov 26, 1:56 PM
Unknown Object (File)
Mon, Nov 25, 3:14 AM
Unknown Object (File)
Thu, Nov 21, 8:37 PM
Unknown Object (File)
Mon, Nov 18, 8:09 AM
Unknown Object (File)
Thu, Nov 14, 10:14 AM
Unknown Object (File)
Sun, Nov 10, 6:09 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
T4195: Implement pre-commit Herald rules
Commits
Restricted Diffusion Commit
rPf28d3089d7d8: Assign PHIDs to PushLogs
Summary

Ref T4195. We need these in Herald, since HeraldTranscripts need to refer to a PHID which they acted upon.

Test Plan

Ran migration, got PHIDs:

mysql> select phid from repository_pushlog limit 3;
+--------------------------------+
| phid                           |
+--------------------------------+
| PHID-PSHL-25jnc6cjgzw5rwqgmr7r |
| PHID-PSHL-2vrvmtslkrj5yv7nxsv2 |
| PHID-PSHL-34x262zkrwoka6mplony |
+--------------------------------+
3 rows in set (0.00 sec)

Diff Detail

Branch
cherald1
Lint
No Lint Coverage
Unit
Tests Passed

Event Timeline

epriestley updated this revision to Unknown Object (????).Dec 17 2013, 8:36 PM
  • Add some trailing newlines.