Make it harder to misconfigure `phpmailer.smtp-protocol`
ClosedPublic
Actions

Authored by epriestley on Dec 16 2013, 8:17 PM.

Tags

None

Referenced Files

	F14501451: D7778.id.diff
	Sat, Jan 4, 3:04 PM

	Unknown Object (File)
	Thu, Jan 2, 10:45 PM

	Unknown Object (File)
	Thu, Jan 2, 2:10 AM

	Unknown Object (File)
	Mon, Dec 30, 2:08 AM

	Unknown Object (File)
	Thu, Dec 26, 7:48 AM

	Unknown Object (File)
	Fri, Dec 20, 11:37 PM

	Unknown Object (File)
	Wed, Dec 11, 6:23 PM

	Unknown Object (File)
	Sat, Dec 7, 10:04 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP537f2eabee91: Make it harder to misconfigure `phpmailer.smtp-protocol`

Summary

Until we implement an "enum" type for config, make this a bit harder to get wrong. A user entered "TLS", but the correct value is "tls". The documentation is consistent about this, but the behavior is sitll surprsing.

Test Plan

eyeballed it

Diff Detail

Branch

lowerproto

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

btrahan accepted this revision.Dec 16 2013, 8:26 PM

Closed by commit rP537f2eabee91 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

adapter/

PhabricatorMailImplementationPHPMailerAdapter.php

1 line

Diff 17585

View Options

src/applications/metamta/adapter/PhabricatorMailImplementationPHPMailerAdapter.php

Make it harder to misconfigure `phpmailer.smtp-protocol`ClosedPublicActions