Allow Herald rules to check for revisions with no reviewers
ClosedPublic
Actions

Authored by epriestley on Dec 11 2013, 8:42 PM.

Tags

None

Referenced Files

	F14070556: D7757.diff
	Wed, Nov 20, 12:45 PM

	F14053108: D7757.id17545.diff
	Fri, Nov 15, 12:51 PM

	F14053107: D7757.id17544.diff
	Fri, Nov 15, 12:51 PM

	F14053105: D7757.id.diff
	Fri, Nov 15, 12:50 PM

	F14053104: D7757.diff
	Fri, Nov 15, 12:50 PM

	F14038540: D7757.id17544.diff
	Mon, Nov 11, 12:20 AM

	F13997220: D7757.diff
	Thu, Oct 24, 3:03 AM

	F13992979: D7757.diff
	Tue, Oct 22, 7:56 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4225: Allow Herald rules to apply the "exist" and "do not exist" conditions to the "Reviewers" field

Commits

Restricted Diffusion Commit
rP6b1ec35cf377: Allow Herald rules to check for revisions with no reviewers

Summary

Fixes T4225. Adds the NON_EXISTS condition to Herald for "Reviewers", and adds a few more conditions which have reasonable meanings.

Test Plan

Used test console to check a revision with reviewers, and another without reviewers. Both produced the expected results.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

coo

Closed by commit rP6b1ec35cf377 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

adapter/

HeraldAdapter.php

18 lines

storage/

HeraldRule.php

2 lines

Diff 17545

View Options

src/applications/herald/adapter/HeraldAdapter.php