Fix fatal in Git hook when a --force push completely rewrites a ref
ClosedPublic
Actions

Authored by epriestley on Dec 11 2013, 8:31 PM.

Tags

None

Referenced Files

	F13909083: D7756.id17543.diff
	Tue, Oct 8, 4:50 PM

	F13909079: D7756.id17546.diff
	Tue, Oct 8, 4:47 PM

	F13908685: D7756.diff
	Tue, Oct 8, 2:11 PM

	Unknown Object (File)
	Sat, Oct 5, 3:59 PM

	Unknown Object (File)
	Wed, Oct 2, 11:10 AM

	Unknown Object (File)
	Sep 4 2024, 5:51 PM

	Unknown Object (File)
	Aug 31 2024, 5:58 AM

	Unknown Object (File)
	Aug 28 2024, 3:16 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4224: Failure when trying to force push

Commits

Restricted Diffusion Commit
rP61c934449d17: Fix fatal in Git hook when a --force push completely rewrites a ref

Summary

Fixes T4224. If you git merge-base A B, and they have no ancestor, the command exits with an error. Assume errors mean "no ancestry" and continue.

Test Plan

Completely rewrite a repository with a --force push.

Diff Detail

Branch

noancestmergebase

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

btrahan accepted this revision.Dec 11 2013, 10:33 PM

Closed by commit rP61c934449d17 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

engine/

DiffusionCommitHookEngine.php

15 lines

Diff 17543

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Fix fatal in Git hook when a --force push completely rewrites a refClosedPublicActions