Raise a better error for malformed `git ls-tree`
ClosedPublic
Actions

Authored by epriestley on Dec 8 2013, 5:28 PM.

Tags

None

Referenced Files

	F13814112: D7744.id17519.diff
	Thu, Sep 19, 3:25 AM

	F13814082: D7744.id17499.diff
	Thu, Sep 19, 3:14 AM

	Unknown Object (File)
	Tue, Sep 17, 1:52 AM

	Unknown Object (File)
	Fri, Sep 6, 6:54 AM

	Unknown Object (File)
	Mon, Sep 2, 3:43 AM

	Unknown Object (File)
	Fri, Aug 30, 9:30 PM

	Unknown Object (File)
	Sat, Aug 24, 6:27 AM

	Unknown Object (File)
	Wed, Aug 21, 12:46 PM

View All Files

Subscribers

aran

Details

Reviewers

hach-que
btrahan

Maniphest Tasks

T4159: Exceptions occurring in Diffusion which result in PHP-FPM worker processes crashing

Commits

Restricted Diffusion Commit
rP52462a46c00c: Raise a better error for malformed `git ls-tree`

Summary

Ref T4159. See T4159 for discussion.

Test Plan

Faked the error and generated a reasonable error message.

Diff Detail

Branch

lstreeout

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

I'll apply this to my server when I get into the office and see what the exception says.

btrahan accepted this revision.Dec 9 2013, 6:45 PM

Closed by commit rP52462a46c00c (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

conduit/

ConduitAPI_diffusion_browsequery_Method.php

9 lines

Diff 17499

View Options

src/applications/diffusion/conduit/ConduitAPI_diffusion_browsequery_Method.php

Raise a better error for malformed `git ls-tree`ClosedPublicActions