Page MenuHomePhabricator

Make nonscalar field saves raise a more useful exception from LiskDAO
ClosedPublic

Authored by epriestley on Dec 6 2013, 1:26 AM.
Tags
None
Referenced Files
F13813485: D7725.id17443.diff
Wed, Sep 18, 11:22 PM
F13813418: D7725.id17466.diff
Wed, Sep 18, 11:06 PM
Unknown Object (File)
Mon, Sep 16, 10:53 AM
Unknown Object (File)
Thu, Aug 29, 7:19 AM
Unknown Object (File)
Tue, Aug 27, 8:36 AM
Unknown Object (File)
Sun, Aug 25, 11:39 AM
Unknown Object (File)
Aug 18 2024, 7:55 AM
Unknown Object (File)
Aug 18 2024, 6:32 AM
Subscribers

Details

Summary

If you do something like this:

// Missing $user->getPHID()!
$object->setUserPHID($user)->save();

...you get a very unhelpful exception:

Expected a scalar or null for %s conversion. Query: %s

This doesn't give you any hints about what's wrong. Instead, provide a more useful exception:

Unable to insert or update object of class DifferentialRevision, field 'title' has a nonscalar value.
Test Plan

{F87614}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped