Page MenuHomePhabricator

Make nonscalar field saves raise a more useful exception from LiskDAO
ClosedPublic

Authored by epriestley on Dec 6 2013, 1:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 29, 8:18 PM
Unknown Object (File)
Sat, Jun 28, 11:18 AM
Unknown Object (File)
Fri, Jun 27, 8:08 PM
Unknown Object (File)
May 7 2025, 7:01 AM
Unknown Object (File)
May 5 2025, 9:19 PM
Unknown Object (File)
Apr 24 2025, 10:56 AM
Unknown Object (File)
Apr 24 2025, 8:40 AM
Unknown Object (File)
Apr 23 2025, 10:45 AM
Subscribers

Details

Summary

If you do something like this:

// Missing $user->getPHID()!
$object->setUserPHID($user)->save();

...you get a very unhelpful exception:

Expected a scalar or null for %s conversion. Query: %s

This doesn't give you any hints about what's wrong. Instead, provide a more useful exception:

Unable to insert or update object of class DifferentialRevision, field 'title' has a nonscalar value.
Test Plan

{F87614}

Diff Detail

Branch
nonscalar
Lint
Lint Passed
Unit
Tests Passed