This migrates the "Run Remote Command" build step over to use Drydock hosts and Harbormaster artifacts.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T1049: Implement Harbormaster
T4111: Use Drydock to allocate build machines for Harbormaster - Commits
- Restricted Diffusion Commit
rP5c02113bf9eb: Migrate "Run Command" to use Drydock hosts
Created a build plan with a "Lease Host" step and a "Run Command" step. Configured the "Run Command" step to use the artifact from the "Lease Host" step.
Saw the results:
{F87377}
{F87378}
Diff Detail
Diff Detail
- Branch
- execute-on-artifact
- Lint
Lint Passed Severity Location Code Message Advice src/applications/harbormaster/step/CommandBuildStepImplementation.php:119 XHP16 TODO Comment - Unit
No Test Coverage
Event Timeline
| src/applications/harbormaster/config/PhabricatorHarbormasterConfigOptions.php | ||
|---|---|---|
| 6 | ||
Comment Actions
Nice!
| src/applications/harbormaster/step/CommandBuildStepImplementation.php | ||
|---|---|---|
| 47 | These are OK for now, I think Drydock predates the widespread use of PolicyQuery. | |