Page MenuHomePhabricator

Introduce HarbormasterBuildTarget to snapshot build steps through a build
ClosedPublic

Authored by hach-que on Dec 5 2013, 12:30 AM.
Tags
None
Referenced Files
F17734136: D7703.id17398.diff
Sun, Jul 20, 10:03 AM
F17734126: D7703.id17404.diff
Sun, Jul 20, 10:02 AM
F17732925: D7703.diff
Sun, Jul 20, 6:28 AM
Unknown Object (File)
Fri, Jun 27, 5:22 PM
Unknown Object (File)
May 30 2025, 7:11 PM
Unknown Object (File)
May 28 2025, 10:55 AM
Unknown Object (File)
May 27 2025, 5:29 PM
Unknown Object (File)
May 7 2025, 4:21 PM

Details

Summary

This implements build targets as outlined in D7582. Build targets represent an instance of a build step particular to the build. Logs and artifacts have been adjusted to attach to build targets instead of build / build step pairs.

Test Plan

Ran builds and clicked around the interface. Everything seemed to work.

Diff Detail

Branch
build-target
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/harbormaster/worker/HarbormasterBuildWorker.php:50XHP16TODO Comment
Unit
Tests Passed

Event Timeline

Awesome, this looks great to me.

src/applications/harbormaster/controller/HarbormasterBuildViewController.php
58

pht()

66

pht