Ref T4189. Fixes T2066. Mercurial has a lot of hooks so I'm not 100% sure this is all we need to install (we may need separate hooks for tags/bookmarks) but it should cover most of what we're after at least.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- Restricted Maniphest Task
T4189: Install commit hooks in hosted repositories - Commits
- Restricted Diffusion Commit
rPf93c6985ad84: Support Mercurial pretxnchangegroup hooks
- bin/repository pull'd a Mercurial repo and got a hook install.
- Pushed to a Mercurial repository over SSH and HTTP, with good/bad hooks. Saw hooks fire.
Diff Detail
Diff Detail
- Branch
- hooks3
- Lint
Lint Passed Severity Location Code Message Advice scripts/repository/commit_hook.php:38 XHP16 TODO Comment Advice src/applications/diffusion/engine/DiffusionCommitHookEngine.php:81 XHP16 TODO Comment - Unit
Tests Passed
Event Timeline
| src/applications/repository/engine/PhabricatorRepositoryPullEngine.php | ||
|---|---|---|
| 340 | This is basically like "--bare" in Git, but should be much less problematic since the Mercurial bare and non-bare formats are almost identical. This is just a little cleaner/faster and saves a bit of disk space by not keeping a checked out working copy around when we don't actually need one. | |