Currently, we assume search will always succeed if bind succeeds, but this isn't true in the wild. We don't have a root cause yet, but blunt this error into something vaguely useful rather than passing null to an array typehint and failing later and less usefully.
Details
Details
- Reviewers
btrahan - Commits
- rPHU9b2211b4ca72: Raise an exception if LDAP search fails
Used bin/auth ldap.
Diff Detail
Diff Detail
- Branch
- ldaperr
- Lint
Lint Passed - Unit
No Test Coverage
Event Timeline
| src/auth/PhutilAuthAdapterLDAP.php | ||
|---|---|---|
| 374 | (This parameter is unused.) | |
Comment Actions
- We tracked the root cause down to anonymous users being able to search, while credentialed users can not.
- This is weird, but seems OK to accommodate.
- After failing a search, try to rebind as anonymous again and redo the search.