Page MenuHomePhabricator
Differential D7622

Have TransactionComments return a PHUIObjectBoxView
ClosedPublic
Actions

Authored by chad on Nov 21 2013, 11:58 PM.
Tags
None
Referenced Files
F14098984: D7622.id17210.diff
Tue, Nov 26, 10:37 AM
F14098983: D7622.id17211.diff
Tue, Nov 26, 10:37 AM
F14098981: D7622.id17212.diff
Tue, Nov 26, 10:36 AM
F14098980: D7622.id.diff
Tue, Nov 26, 10:36 AM
F14098861: D7622.diff
Tue, Nov 26, 10:17 AM
Unknown Object (File)
Sat, Nov 23, 9:41 AM
Unknown Object (File)
Sat, Nov 23, 7:21 AM
Unknown Object (File)
Tue, Nov 19, 2:56 AM
View All Files
Subscribers
aran
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T4053: Macro Preview Box needs fixing
Commits
Restricted Diffusion Commit
rPb154b07f0e9e: Have TransactionComments return a PHUIObjectBoxView
Summary

Simplifies the code a bit and fixes all the wonky previews. Fixes T4053

Test Plan

Test all pages, logged in and logged out.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley accepted this revision.Nov 21 2013, 11:59 PM
chad updated this revision to Unknown Object (????).Nov 22 2013, 12:15 AM
  • text
chad closed this revision.Nov 22 2013, 12:16 AM

Closed by commit rPb154b07f0e9e (authored by @chad).

Revision Contents
Changeset List

PathSize
src/
94 lines
applications/
files/
controller/
16 lines
legalpad/
controller/
9 lines
macro/
controller/
16 lines
maniphest/
controller/
7 lines
paste/
controller/
16 lines
pholio/
controller/
9 lines
ponder/
controller/
16 lines
releeph/
controller/
request/
13 lines
slowvote/
controller/
16 lines
transactions/
view/
49 lines
webroot/
rsrc/
css/
phui/
3 lines

Diff 17212

View Options

src/__celerity_resource_map__.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileInfoController.php

Loading...
View Options

src/applications/legalpad/controller/LegalpadDocumentViewController.php

Loading...
View Options

src/applications/macro/controller/PhabricatorMacroViewController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

src/applications/paste/controller/PhabricatorPasteViewController.php

Loading...
View Options

src/applications/pholio/controller/PholioMockViewController.php

Loading...
View Options

src/applications/ponder/controller/PonderQuestionViewController.php

Loading...
View Options

src/applications/releeph/controller/request/ReleephRequestViewController.php

Loading...
View Options

src/applications/slowvote/controller/PhabricatorSlowvotePollController.php

Loading...
View Options

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-form-view.css

Loading...
Phabricator · Built by Phacility