Page MenuHomePhabricator
Differential D7576

Implement an approval queue
ClosedPublic
Actions

Authored by epriestley on Nov 13 2013, 4:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 10:02 PM
Unknown Object (File)
Sun, Dec 8, 7:23 PM
Unknown Object (File)
Sat, Dec 7, 3:37 PM
Unknown Object (File)
Sat, Dec 7, 2:51 AM
Unknown Object (File)
Fri, Dec 6, 9:41 PM
Unknown Object (File)
Fri, Dec 6, 4:40 PM
Unknown Object (File)
Fri, Dec 6, 1:13 PM
Unknown Object (File)
Fri, Dec 6, 4:55 AM
View All Files
Subscribers
aran
chad

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rPc0e1a63a63ae: Implement an approval queue
Summary
  • Add an option for the queue.
  • By default, enable it.
  • Dump new users into the queue.
  • Send admins an email to approve them.
Test Plan
  • Registered new accounts with queue on and off.
  • As an admin, approved accounts and disabled the queue from email.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Nov 13 2013, 4:49 AM
  • Automatically approve users created through unit tests, etc.
btrahan accepted this revision.Nov 13 2013, 6:30 PM

This is something that would make a nice Nuance queue some day. (Then you'd get transactions and stuff around the edits)

Obviously on me to make that even remotely possible.

epriestley added a comment.Nov 13 2013, 6:54 PM

:P

epriestley closed this revision.Nov 13 2013, 7:25 PM

Closed by commit rPc0e1a63a63ae (authored by @epriestley).

chad added a comment.Dec 5 2013, 4:23 PM

Is it email approval only? Should we surface this in the UI somewhere?

epriestley added a comment.Dec 5 2013, 4:25 PM

D7574 added the UI part.

https://secure.phabricator.com/people/query/approval/

chad added a comment.Dec 5 2013, 4:30 PM

oh I was CC'd and never followed up. I will play with this.

epriestley mentioned this in D17503: Add Badges to UserCache.Mar 17 2017, 6:41 PM

Revision Contents
Changeset List

PathSize
scripts/
user/
1 line
1 line
src/
applications/
auth/
controller/
56 lines
config/
controller/
2 lines
option/
49 lines
people/
controller/
3 lines
storage/
2 lines
infrastructure/
testing/
3 lines

Diff 17107

View Options

scripts/user/account_admin.php

Loading...
View Options

scripts/user/add_user.php

Loading...
View Options

src/applications/auth/controller/PhabricatorAuthRegisterController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigEditController.php

Loading...
View Options

src/applications/config/option/PhabricatorAuthenticationConfigOptions.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleEditController.php

Loading...
View Options

src/applications/people/storage/PhabricatorUser.php

Loading...
View Options

src/infrastructure/testing/PhabricatorTestCase.php

Loading...
Phabricator · Built by Phacility