Ref T2230. This simplifies some tests and cleans up some TODOs in the hosting stuff. See testCloseExecWriteChannel for an example of where we need this in practice.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- Restricted Maniphest Task
- Commits
- rPHU3ef0937680ad: Allow PhutilChannels to have their write channels closed explicitly
Ran unit tests; commented out the closeWriteChannel() calls and got test failures instead of hangs.
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
- Also fix an issue with reading remaining messages off a channel after it has closed but before its buffer has emptied.