Page MenuHomePhabricator

Add a "Make an HTTP Request" build step
ClosedPublic

Authored by epriestley on Nov 9 2013, 3:27 AM.
Tags
None
Referenced Files
F13298564: D7541.diff
Fri, Jun 7, 6:57 AM
F13292108: D7541.id.diff
Wed, Jun 5, 1:34 AM
F13281962: D7541.diff
Sun, Jun 2, 11:31 AM
F13267439: D7541.diff
Wed, May 29, 3:21 AM
F13260073: D7541.id17029.diff
Sun, May 26, 11:28 PM
F13252973: D7541.diff
Sat, May 25, 2:16 AM
F13249842: D7541.id.diff
Fri, May 24, 11:19 AM
F13238692: D7541.id17018.diff
Tue, May 21, 8:39 PM
Subscribers

Details

Summary

Ref T1049. This is very minimal, but does what it says.

I merged the variable replacement code so Remote + HTTP can share more stuff.

Test Plan

Ran "HTTP" and "Remote" build plans.

{F79886}

{F79887}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/harbormaster/controller/HarbormasterBuildCancelController.php
29

This is because MySQL complains about setting BOOLEAN columns to '' when it's in strict mode. We should probably do a better job of abstracting this, but for now just use 1 and 0 explicitly.

Tested this against both http://www.google.com/ and http://code.redpointsoftware.com.au/. Google throws a lovely 405 Method Not Allowed and thus the build fails. My Phabricator instance returns 200 OK and the build passes.