Page MenuHomePhabricator

Add a "Make an HTTP Request" build step
ClosedPublic

Authored by epriestley on Nov 9 2013, 3:27 AM.
Tags
None
Referenced Files
F18733066: D7541.diff
Tue, Sep 30, 9:11 PM
F18670750: D7541.diff
Thu, Sep 25, 1:22 AM
F18512966: D7541.diff
Fri, Sep 5, 8:46 AM
F18446663: D7541.id.diff
Aug 31 2025, 10:11 PM
F18424382: D7541.diff
Aug 30 2025, 8:53 PM
F18207243: D7541.id17018.diff
Aug 18 2025, 5:04 PM
F17948258: D7541.id17029.diff
Jul 31 2025, 8:34 PM
F17933957: D7541.id.diff
Jul 30 2025, 9:46 PM
Subscribers

Details

Summary

Ref T1049. This is very minimal, but does what it says.

I merged the variable replacement code so Remote + HTTP can share more stuff.

Test Plan

Ran "HTTP" and "Remote" build plans.

{F79886}

{F79887}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/harbormaster/controller/HarbormasterBuildCancelController.php
29

This is because MySQL complains about setting BOOLEAN columns to '' when it's in strict mode. We should probably do a better job of abstracting this, but for now just use 1 and 0 explicitly.

Tested this against both http://www.google.com/ and http://code.redpointsoftware.com.au/. Google throws a lovely 405 Method Not Allowed and thus the build fails. My Phabricator instance returns 200 OK and the build passes.