Page MenuHomePhabricator

Add a "Make an HTTP Request" build step
ClosedPublic

Authored by epriestley on Nov 9 2013, 3:27 AM.
Tags
None
Referenced Files
F14064130: D7541.diff
Mon, Nov 18, 9:55 PM
F14033521: D7541.diff
Sat, Nov 9, 5:54 PM
F13981736: D7541.id17018.diff
Oct 19 2024, 6:45 PM
F13966329: D7541.diff
Oct 16 2024, 7:34 AM
Unknown Object (File)
Oct 10 2024, 5:34 AM
Unknown Object (File)
Oct 9 2024, 2:59 PM
Unknown Object (File)
Oct 9 2024, 2:59 PM
Unknown Object (File)
Oct 9 2024, 2:59 PM
Subscribers

Details

Summary

Ref T1049. This is very minimal, but does what it says.

I merged the variable replacement code so Remote + HTTP can share more stuff.

Test Plan

Ran "HTTP" and "Remote" build plans.

{F79886}

{F79887}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/harbormaster/controller/HarbormasterBuildCancelController.php
29

This is because MySQL complains about setting BOOLEAN columns to '' when it's in strict mode. We should probably do a better job of abstracting this, but for now just use 1 and 0 explicitly.

Tested this against both http://www.google.com/ and http://code.redpointsoftware.com.au/. Google throws a lovely 405 Method Not Allowed and thus the build fails. My Phabricator instance returns 200 OK and the build passes.