I've kept this as close as possible to the Git version for ease of review and later refactoring of them both together. At minimum, the functions to get the working dir should probably be cleaned up one day.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T182: Commit into repository directly from differential
- Commits
- Restricted Diffusion Commit
rPd700e7f22d6d: Add support for landing to hosted Mercurial repos.
Landed a revision.
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
One inline -- walk me through that? Everything else looks good.
| src/applications/differential/DifferentialGetWorkingCopy.php | ||
|---|---|---|
| 54 | This is surprising -- I'd expect it to be file://, so the result is like file:///path/to/something. Does that not work? It seems to work correctly on my local machine: >>> orbital ~/repos $ hg clone file:///Users/epriestley/repos/hg-working-copy new-clone updating to branch default 7 files updated, 0 files merged, 0 files removed, 0 files unresolved >>> orbital ~/repos $ | |
| src/applications/differential/landing/DifferentialLandingStrategy.php | ||
| 49–50 | OMG THESE TABSPACES ARE NOT COMPLETELY ACCUCATE | |
| src/applications/differential/DifferentialGetWorkingCopy.php | ||
|---|---|---|
| 54 | file:// only seems to work if given an absolute path, just file: alone is happy with both. The former seems to be a silly bug with Mercurial being overzealous, so I went with the latter as it seemed like it would be more reliable. Could change it for consistency, I don't know if there are any other implications. | |
| src/applications/differential/landing/DifferentialLandingStrategy.php | ||
| 49–50 | SHRIEK Please fix it in the pull lest I bring shame upon my family. | |
Comment Actions
Alright -- I'm going to swap it for file:// for consistency, since non-absolute paths shouldn't exist and may have weird security implications, so it's probably better if it breaks. We'll have stronger guarantees around this in the future.