Page MenuHomePhabricator
Differential D7481

Handle empty output from `hg --debug branches` in the parser
ClosedPublic
Actions

Authored by epriestley on Nov 2 2013, 7:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 1:33 AM
Unknown Object (File)
Thu, May 2, 8:19 PM
Unknown Object (File)
Thu, May 2, 10:39 AM
Unknown Object (File)
Sat, Apr 27, 11:22 PM
Unknown Object (File)
Fri, Apr 12, 1:47 PM
Unknown Object (File)
Fri, Apr 12, 11:46 AM
Unknown Object (File)
Fri, Apr 12, 11:46 AM
Unknown Object (File)
Fri, Apr 12, 10:56 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T1493: Empty repositories should show a "this repository is empty" message
Commits
rARC9310df961540: Handle empty output from `hg --debug branches` in the parser
Summary

Ref T1493. Also consolidate this a bit more.

Test Plan

Unit tests.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan accepted this revision.Nov 2 2013, 8:53 PM

Is there a bug in the presentation of this diff? branches-empty.txt seems confusing - is it an empty file maybe?

epriestley added a comment.Nov 2 2013, 8:55 PM

It's an empty file, yes. The display seems buggy to me.

epriestley closed this revision.Nov 4 2013, 8:16 PM

Closed by commit rARC9310df961540 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
repository/
api/
19 lines
parser/
8 lines
__tests__/
4 lines
mercurial/

Diff 16891

View Options

src/repository/api/ArcanistMercurialAPI.php

Loading...
View Options

src/repository/parser/ArcanistMercurialParser.php

Loading...
View Options

src/repository/parser/__tests__/ArcanistMercurialParserTestCase.php

Loading...
View Options

src/repository/parser/__tests__/mercurial/branches-empty.txt

Loading...
Phabricator · Built by Phacility