This fixes an issue where Git authentication would always fail on an install with policy.allow-public set to false. This is because when public access is allowed, anonymous users can query the user list. However, when public access is not allowed, you have to be authenticated before you can read any of the user objects.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T4049: Phabricator Git authentication does not work on non-public installation
- Commits
- Restricted Diffusion Commit
rP0ceb53bfae28: Fix issue where Git authentication would always 403 on non-public install.
Prior to this fix, I get:
james@james-laptop:~/git/8> git clone http://phabricator.local/diffusion/TEST/ Cloning into 'TEST'... fatal: unable to access 'http://phabricator.local/diffusion/TEST/': The requested URL returned error: 403
when policy.allow-public is false. After this fix I get:
james@james-laptop:~/git/8> git clone http://phabricator.local/diffusion/TEST/ Cloning into 'TEST'... remote: Counting objects: 102, done. remote: Compressing objects: 100% (71/71), done. remote: Total 102 (delta 6), reused 0 (delta 0) Receiving objects: 100% (102/102), 9.89 KiB | 0 bytes/s, done. Resolving deltas: 100% (6/6), done. Checking connectivity... done
Diff Detail
Diff Detail
- Branch
- fix-nonpublic-access
- Lint
Lint Passed - Unit
No Test Coverage